X-Profile-Data value is a string #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some middlewares expect all of the response headers to be String but X-Profile-Data is currently a Pathname. This commit change it so that it's explicitly converted to a String, before sending the value downstream.
gmcgibbon
approved these changes
Dec 14, 2021
| @@ -44,6 +44,7 @@ class UploadActionTest < AppProfiler::TestCase | |||
|
|
|||
| assert_predicate(@response[1][AppProfiler.profile_header], :present?) | |||
| assert_predicate(@response[1][AppProfiler.profile_data_header], :present?) | |||
| assert_equal(@response[1][AppProfiler.profile_data_header].class, String) | |||
There was a problem hiding this comment.
Suggested change
| assert_equal(@response[1][AppProfiler.profile_data_header].class, String) | |
| assert_kind_of(String, @response[1][AppProfiler.profile_data_header]) |
dalehamel
approved these changes
Dec 14, 2021
|
FWIW the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some middlewares expect all of the response headers values to be
Stringbut X-Profile-Data is currently emitting aPathname. This commit change it so that it is explicitly converted to a String, before sending the value downstream.I ran into an issue specifically with thin where it was parsing the response headers and raised the following error:
Is there a reason to use Pathname over String?